Using custom named temporary file. #1222
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This is so that tests can run successfully on Windows. In addition, using generic integer types (from `six`) for `gcloud._helpers._millis_from_datetime` since it returns a `long` on Windows and `int` on Linux. Also monkey patching the GCE ID check in `test_ctor_w_dataset_id_no_environ` since some CI environments will give a "false positive" on that test.
3363d5e to
85d8371
Compare
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Nov 18, 2015
Using custom named temporary file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that tests can run successfully on Windows.
In addition, using generic integer types (from
six) forgcloud._helpers._millis_from_datetimesince it returns alongon Windows andinton Linux. Also monkey patching the GCE ID check intest_ctor_w_dataset_id_no_environsince some CI environments will give a "false positive" on that test.