Allowing datastore system test to run on emulator with no connection. #1386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the GOOGLE_APPLICATION_CREDENTIALS is used and an access token is minted even though requests to the emulator require no authentication.
|
By allowing the default behavior to occur, an |
|
@pcostell Is it intended that the emulator doesn't check the value of the |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Jan 15, 2016
Allowing datastore system test to run on emulator with no connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
GOOGLE_APPLICATION_CREDENTIALSis used and an access token is minted even though requests to the emulator require no authentication.