Adding cluster argument to Bigtable HappyBase connection. #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tseaver PTAL |
|
@jgeewax PTAL (pending question for you) |
5166b05 to
9c40113
Compare
|
Resolved with @jgeewax that warnings and |
|
LGTM |
dhermes
added a commit
that referenced
this pull request
Feb 12, 2016
Adding cluster argument to Bigtable HappyBase connection.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tseaver By adding this I go from 10 to 11 arguments (10 are part of the original interface) and I makepylintangry.Would you prefer I
**kwargsfor supporting the legacy signature (this breaks any argument order unless we also use*argsand manually do the mapping, which would break existing code that useshappybase)pylint: disable=locally@jgeewax How important is having the signature of our
gcloud.bigtable.happybase.Connectionthe same ashappybase.Connection?