Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dhermes
Copy link
Contributor

@dhermes dhermes commented Oct 3, 2016

NOTE: Has #2475 as diffbase.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2016
@daspecster
Copy link
Contributor

@dhermes this has a conflict too. Otherwise LGTM.

@dhermes dhermes force-pushed the collapse-travis-config-3 branch from e2dd6ca to 324a2c3 Compare October 3, 2016 20:43
@dhermes
Copy link
Contributor Author

dhermes commented Oct 3, 2016

@daspecster I just rebased and it seemed to fix itself?

@dhermes dhermes merged commit 72291ea into googleapis:master Oct 3, 2016
@dhermes dhermes deleted the collapse-travis-config-3 branch October 3, 2016 20:51
@dhermes
Copy link
Contributor Author

dhermes commented Oct 3, 2016

Build time down from 20 minutes to about 7.5 minutes. But it used to be consistently under 4, so I still have work to do.

@tseaver
Copy link
Contributor

tseaver commented Oct 3, 2016

I don't see any special handling for changes in core/ -- because it is a dependency for everything else, should we be falling back to running all tests when any change happens there?

@dhermes
Copy link
Contributor Author

dhermes commented Oct 3, 2016

@tseaver I've got a change coming down the pipe which computes a package dependency graph and then follows the tree to populate a more-full list of changes. Thanks for being heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants