Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generate gapic for logging, remove all references to gax #4759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
theacodes merged 5 commits into from
Jan 19, 2018
Merged

Generate gapic for logging, remove all references to gax #4759

theacodes merged 5 commits into from
Jan 19, 2018

Conversation

@theacodes
Copy link
Contributor

@theacodes theacodes commented Jan 18, 2018

Towards #4692.

This was not fun. Once again, I recommend reviewing commit-by-commit (there's only 2)

@theacodes theacodes requested a review from waprin as a code owner January 18, 2018 00:06
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2018
tseaver
tseaver reviewed Jan 18, 2018
View reviewed changes
logging/docs/conf.py
@@ -0,0 +1,310 @@
# -*- coding: utf-8 -*-

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/google/cloud/logging_v2/__init__.py
'LoggingServiceV2Client',
'ConfigServiceV2Client',
'MetricsServiceV2Client',
)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/google/cloud/logging_v2/gapic/metrics_service_v2_client_config.py
}
}
}
}

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/google/cloud/logging_v2/types.py
for name, message in get_messages(module).items():
message.__module__ = 'google.cloud.logging_v2.types'
setattr(sys.modules[__name__], name, message)
names.append(name)

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/tests/system/test_system.py
# limitations under the License.

import datetime
import logging

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

logging/tests/unit/test_client.py Outdated
self.assertEqual(client.project, self.PROJECT)

def test_logging_api_wo_gax(self):
def test_logging_api_wo_gapi(self):

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

lukesneeringer
lukesneeringer reviewed Jan 18, 2018
View reviewed changes
logging/setup.py
'google-api-core >= 0.1.1, < 0.2.0dev',
'gapic-google-cloud-logging-v2 >= 0.91.0, < 0.92dev',
'google-cloud-core >= 0.28.0, < 0.29dev',
'google-api-core[grpc] >= 0.1.1, < 0.2.0dev',

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@theacodes
Copy link
Contributor Author

theacodes commented Jan 18, 2018

CI is failing due to bigquery non-determinism (addressing in #4760), will rebase and merge when CI is greeeen.

@theacodes theacodes force-pushed the regen-logging-gapic branch from 3130c26 to 13f45fd Compare January 18, 2018 23:38
@chemelnucfin chemelnucfin added type: process A process-related concern. May include testing, release, or the like. api: logging Issues related to the Cloud Logging API. labels Jan 19, 2018
@theacodes theacodes force-pushed the regen-logging-gapic branch from 13f45fd to d14b71f Compare January 19, 2018 21:35
@theacodes theacodes mentioned this pull request Jan 19, 2018
Closed
Jon Wayne Parrott added 5 commits January 19, 2018 14:15
Import logging_v2 generated by artman
0f3d38f 
Command log:

```
set DEST ~/workspace/google-cloud-python/logging
set GOOGLEAPIS_REV fca7f0706769f8ece08121a87394b7c6e6d87687

cd /tmp
git clone https://github.com/googleapis/googleapis.git
cd googleapis
git reset --hard $GOOGLEAPIS_REV
artman --config google/logging/artman_logging.yaml generate python_gapic
set SRC ./artman-genfiles/python/logging-v2/
set IMPORT_PKG logging_v2
cp -r $SRC/docs $DEST
cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/
mkdir -p $DEST/tests/unit/gapic
cp -r $SRC/tests/unit/gapic $DEST/tests/unit
mkdir -p $DEST/tests/system/gapic
cp -r $SRC/tests/system/gapic $DEST/tests/system
```
Removing all references to gax
c0ddd73
Fix typo
f8f3fbc
Add missing encoding
81eef21
Remove unused test helper
24fd8e5
@theacodes theacodes force-pushed the regen-logging-gapic branch from 342bf15 to 24fd8e5 Compare January 19, 2018 22:15
@theacodes theacodes merged commit 14ee26f into master Jan 19, 2018
@theacodes theacodes deleted the regen-logging-gapic branch January 19, 2018 23:15
@theacodes theacodes mentioned this pull request Feb 9, 2018
Closed
8 tasks
parthea pushed a commit that referenced this pull request Nov 24, 2025
Generate gapic for logging, remove all references to gax (#4759)
0caaf78 
* Import logging_v2 generated by artman

Command log:

```
set DEST ~/workspace/google-cloud-python/logging
set GOOGLEAPIS_REV fca7f0706769f8ece08121a87394b7c6e6d87687

cd /tmp
git clone https://github.com/googleapis/googleapis.git
cd googleapis
git reset --hard $GOOGLEAPIS_REV
artman --config google/logging/artman_logging.yaml generate python_gapic
set SRC ./artman-genfiles/python/logging-v2/
set IMPORT_PKG logging_v2
cp -r $SRC/docs $DEST
cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/
mkdir -p $DEST/tests/unit/gapic
cp -r $SRC/tests/unit/gapic $DEST/tests/unit
mkdir -p $DEST/tests/system/gapic
cp -r $SRC/tests/system/gapic $DEST/tests/system
```

* Removing all references to gax

* Fix typo

* Add missing encoding

* Remove unused test helper
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@waprin waprin Awaiting requested review from waprin

2 more reviewers

@tseaver tseaver tseaver left review comments

@lukesneeringer lukesneeringer lukesneeringer approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. type: process A process-related concern. May include testing, release, or the like.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@theacodes @lukesneeringer @tseaver @chemelnucfin @googlebot