-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Regenerate gapic for Trace and remove dependency on gax #4799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Command log: ``` set DEST ~/workspace/google-cloud-python/trace set GOOGLEAPIS_REV origin/master cd /tmp git clone https://github.com/googleapis/googleapis.git cd googleapis git reset --hard $GOOGLEAPIS_REV artman --config google/devtools/cloudtrace/artman_cloudtrace_v1.yaml generate python_gapic artman --config google/devtools/cloudtrace/artman_cloudtrace_v2.yaml generate python_gapic set SRC ./artman-genfiles/python/trace-v1/ set IMPORT_PKG trace_v1 cp -r $SRC/docs $DEST cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/ mkdir -p $DEST/tests/unit/gapic cp -r $SRC/tests/unit/gapic $DEST/tests/unit mkdir -p $DEST/tests/system/gapic cp -r $SRC/tests/system/gapic $DEST/tests/system set SRC ./artman-genfiles/python/trace-v2/ set IMPORT_PKG trace_v2 cp -r $SRC/docs $DEST cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/ mkdir -p $DEST/tests/unit/gapic cp -r $SRC/tests/unit/gapic $DEST/tests/unit mkdir -p $DEST/tests/system/gapic cp -r $SRC/tests/system/gapic $DEST/tests/system ```
bf94161 to
11969f7
Compare
theacodes
approved these changes
Feb 2, 2018
Contributor
|
Thanks @chemelnucfin! Can you draft a release of this? |
Contributor
Author
|
@jonparrott Merge it first? |
Contributor
|
yep |
8 tasks
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
* Import trace_v1 and trace_v2 generated by artman Command log: ``` set DEST ~/workspace/google-cloud-python/trace set GOOGLEAPIS_REV origin/master cd /tmp git clone https://github.com/googleapis/googleapis.git cd googleapis git reset --hard $GOOGLEAPIS_REV artman --config google/devtools/cloudtrace/artman_cloudtrace_v1.yaml generate python_gapic artman --config google/devtools/cloudtrace/artman_cloudtrace_v2.yaml generate python_gapic set SRC ./artman-genfiles/python/trace-v1/ set IMPORT_PKG trace_v1 cp -r $SRC/docs $DEST cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/ mkdir -p $DEST/tests/unit/gapic cp -r $SRC/tests/unit/gapic $DEST/tests/unit mkdir -p $DEST/tests/system/gapic cp -r $SRC/tests/system/gapic $DEST/tests/system set SRC ./artman-genfiles/python/trace-v2/ set IMPORT_PKG trace_v2 cp -r $SRC/docs $DEST cp -r $SRC/google/cloud/$IMPORT_PKG $DEST/google/cloud/ mkdir -p $DEST/tests/unit/gapic cp -r $SRC/tests/unit/gapic $DEST/tests/unit mkdir -p $DEST/tests/system/gapic cp -r $SRC/tests/system/gapic $DEST/tests/system ``` * Fix bug in autogen: invalid import paths in proto files * Remove references to gax * Trace: Fix tests after replacing gax with gapic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: cloudtrace
Issues related to the Cloud Trace API.
cla: yes
This human has signed the Contributor License Agreement.
type: cleanup
An internal cleanup or hygiene concern.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #4692