Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@theacodes
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2018
@theacodes theacodes requested a review from crwilcox April 27, 2018 20:56
@tseaver
Copy link
Contributor

tseaver commented Apr 27, 2018

Should the changelog mention #5256? Or is that a fix to unreleased code?

@theacodes
Copy link
Contributor Author

Should the changelog mention #5256? Or is that a fix to unreleased code?

Its in the one big note that references a lot of PRs.

@tseaver
Copy link
Contributor

tseaver commented Apr 27, 2018

Got it. LGTM

@theacodes theacodes merged commit 6f73d1a into master Apr 27, 2018
@theacodes theacodes deleted the release-pubsub-0.34.0 branch April 27, 2018 22:36
@theacodes
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants