Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mcdonc
Copy link
Contributor

@mcdonc mcdonc commented Jun 15, 2018

This fixes the issue at #4675 where fetch executions that pass the offset parameter would return incorrect result values

Closes #4675.

@mcdonc mcdonc requested a review from theacodes as a code owner June 15, 2018 18:56
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 15, 2018
@mcdonc
Copy link
Contributor Author

mcdonc commented Jun 15, 2018

@theacodes apologies, I did not have the email account I am using for Google communications associated with my GitHub account; I think that the Agendaless CLA has already been updated to include that account. I've now done that and to prevent future cla: no issues I've set user.email for my checkout of this repo to that email ([email protected]). If I need to do anything else, please let know. Thanks!

@theacodes
Copy link
Contributor

@mcdonc no worries. Before I go and human-approve this, can you try re-writing your commits to update the author with the proper email? Should be able to do git commit --amend --update-author --no-edit and then git push -f.

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 15, 2018
@mcdonc
Copy link
Contributor Author

mcdonc commented Jun 15, 2018

@theacodes done and looks like googlebot cla-approved the result; thanks!

@theacodes
Copy link
Contributor

theacodes commented Jun 15, 2018 via email

@tseaver tseaver merged commit fde9b59 into googleapis:master Jun 15, 2018
@tseaver tseaver added the api: datastore Issues related to the Datastore API. label Jun 15, 2018
enriquejosepadilla pushed a commit to enriquejosepadilla/google-cloud-python that referenced this pull request Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datastore query offsets are not working as it supposed to
4 participants