-
Notifications
You must be signed in to change notification settings - Fork 1.6k
The offset param to the fetch method of a query did not work properly one there was a cursor #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@theacodes apologies, I did not have the email account I am using for Google communications associated with my GitHub account; I think that the Agendaless CLA has already been updated to include that account. I've now done that and to prevent future cla: no issues I've set user.email for my checkout of this repo to that email ([email protected]). If I need to do anything else, please let know. Thanks! |
@mcdonc no worries. Before I go and human-approve this, can you try re-writing your commits to update the author with the proper email? Should be able to do |
… once there was a cursor; see #4675
CLAs look good, thanks! |
@theacodes done and looks like googlebot cla-approved the result; thanks! |
Yay. Thank you!
…On Fri, Jun 15, 2018 at 12:57 PM Chris McDonough ***@***.***> wrote:
@theacodes <https://github.com/theacodes> done and looks like googlebot
cla-approved the result; thanks!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#5503 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAPUc5LXPhngMOS-uqBSRuGh8HDwfI5Rks5t9BGrgaJpZM4UqAhP>
.
|
This fixes the issue at #4675 where fetch executions that pass the offset parameter would return incorrect result values
Closes #4675.