Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Spanner: add support for session / pool labels #5734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Aug 6, 2018
Merged

Spanner: add support for session / pool labels #5734

merged 10 commits into from
Aug 6, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 2, 2018 •
edited
Loading

Labels are assigned to a pool at creation time, and then get propagated to the sessions created by the pool.

@tseaver tseaver added the api: spanner Issues related to the Spanner API. label Aug 2, 2018
@tseaver tseaver requested a review from theacodes August 2, 2018 17:29
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 2, 2018
@tseaver tseaver force-pushed the spanner-session_pool-labels branch from 6b57b0a to b35edfa Compare August 2, 2018 17:30
@tseaver tseaver force-pushed the spanner-session_pool-labels branch from 33f271d to bcc8fde Compare August 2, 2018 20:20
@tseaver
Copy link
Contributor Author

tseaver commented Aug 2, 2018

/cc @snehashah16

mcdonc
mcdonc suggested changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@mcdonc mcdonc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the note I added. I'll approve once you address that.

spanner/google/cloud/spanner_v1/pool.py
labels = {}
self._labels = labels

@property

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@tseaver tseaver merged commit e36e986 into master Aug 6, 2018
@tseaver tseaver deleted the spanner-session_pool-labels branch August 6, 2018 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes Awaiting requested review from theacodes

1 more reviewer

@mcdonc mcdonc mcdonc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @mcdonc @googlebot