Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Run 'unit_grpc_gcp' tests only with Python 2.7 / 3.6. #5871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2018
Merged

Run 'unit_grpc_gcp' tests only with Python 2.7 / 3.6. #5871

merged 1 commit into from
Sep 7, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Aug 30, 2018

No description provided.

@tseaver tseaver added testing api: spanner Issues related to the Spanner API. labels Aug 30, 2018
@tseaver tseaver requested a review from crwilcox August 30, 2018 15:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 30, 2018
@tseaver tseaver requested a review from mcdonc August 30, 2018 15:32
crwilcox
crwilcox suggested changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@crwilcox crwilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with not running on all of the 3.x versions, but why 3.6 instead of 3.7?

@tseaver
Copy link
Contributor Author

tseaver commented Sep 4, 2018

why 3.6 instead of 3.7?

Those are the same versions for which we run system tests. 3.6 is the system python3 on current LTS Linux releases.

@tseaver tseaver merged commit 6bad253 into googleapis:master Sep 7, 2018
@tseaver tseaver deleted the 5863-spanner-drop_excess_gcp_testing branch September 7, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonc mcdonc Awaiting requested review from mcdonc

1 more reviewer

@crwilcox crwilcox crwilcox requested changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot