Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Re-generate library using monitoring/synth.py #5952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dpebot wants to merge 2 commits into from
Closed

Re-generate library using monitoring/synth.py #5952

dpebot wants to merge 2 commits into from

Conversation

@dpebot
Copy link
Contributor

@dpebot dpebot commented Sep 12, 2018

This PR was created by autosynth.

@dpebot dpebot requested a review from theacodes as a code owner September 12, 2018 12:16
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 12, 2018
@tseaver tseaver added api: monitoring Issues related to the Cloud Monitoring API. codegen labels Sep 12, 2018
tseaver
tseaver suggested changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code gen is massively busted: see https://circleci.com/gh/GoogleCloudPlatform/google-cloud-python/8045

@tseaver tseaver added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 12, 2018
@tseaver
Copy link
Contributor

tseaver commented Sep 12, 2018

@lukesneeringer I'm hoping you have a better shot at finding out what is broken in the protos.

@tseaver tseaver mentioned this pull request Sep 24, 2018
Merged
@tseaver
Copy link
Contributor

tseaver commented Sep 24, 2018

@lukesneeringer We need a non-beta release of googleapis-common-protos 1.6.0 to make synth.py work against current protos for monitoring (and logging, as in PR #6081).

@tseaver tseaver added the status: blocked Resolving the issue is dependent on other work. label Sep 25, 2018
@tseaver
Copy link
Contributor

tseaver commented Oct 31, 2018

I'm going to close this one and let @dpebot autosynth a new one, now that googleapis-common-protos 1.5.5 is out.

@tseaver tseaver closed this Oct 31, 2018
@tseaver tseaver deleted the autosynth-monitoring branch October 31, 2018 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theacodes theacodes Awaiting requested review from theacodes

1 more reviewer

@tseaver tseaver tseaver requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lukesneeringer lukesneeringer

Labels

api: monitoring Issues related to the Cloud Monitoring API. cla: yes This human has signed the Contributor License Agreement. codegen do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dpebot @tseaver @lukesneeringer @googlebot