Spanner: add 'synth.py' for the three protos and regen #6040
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
approved these changes
Sep 20, 2018
b7d43af to
2754fe7
Compare
|
Ugh, pip's extras mishandling strikes again. I'm adding |
Remove crufty grpc_gcp test.
pip's extras mishandling prevents it being installed implicitly.
76f1cd3 to
470fb5a
Compare
mcdonc
approved these changes
Sep 21, 2018
There was a problem hiding this comment.
I would have rather seen some indenting (function or if block) in synth.py, cuz right now it gets executed if imported, which I can only imagine would have some unexpected consequences, if you didn't know what synthtool was. But after conversation with Tres, it seems this is a feature of the framework, sooo... LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.