Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 3, 2018

Blocked pending new rollout of back-end feature.

tseaver added 12 commits October 2, 2018 11:19
With DML statements, there may be no explicit mutations tracked on
the client side.
Switch the still-failing system test to use it.
Assert that stats have appropriate row count.
Required for executing multiple DML statements w/in context of one
transaction.

Update system tests for DML to exercise this (they previously passed only
one statement).
- Rollback transaction after performing DML.
- Mix DML and batch-style mutations in a single commit.
Also, drop the 'partition' argument to it:  not appropriate to the
usecase.
* Add 'Datatbase.execute_partitioned_dml' method.

* Add system test which exercises PDML. both for UPDATE (with parameter)
  and DELETE.
@tseaver tseaver added do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. api: spanner Issues related to the Spanner API. labels Oct 3, 2018
@tseaver tseaver requested a review from theacodes as a code owner October 3, 2018 02:59
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 3, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 3, 2018

/cc @snehashah16

@tseaver tseaver removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. status: blocked Resolving the issue is dependent on other work. labels Oct 8, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 8, 2018

DML / PDML system tests are passing for non-whitelisted projects. Merging and preparing release, per @snehashah16.

@tseaver tseaver merged commit c8bda0f into master Oct 8, 2018
@tseaver tseaver deleted the spanner-dml-prep_for_public branch October 8, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants