Thanks to visit codestin.com
Credit goes to github.com

Skip to content

api_core: fix import order, appeasing lint. #6240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

api_core: fix import order, appeasing lint. #6240

merged 1 commit into from
Oct 17, 2018

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 17, 2018 •
edited
Loading

@tseaver
Fix import order, appeasing lint.
2daca03 
Error left from PR #6211, when Kokoro was blithely skipping tests.
@tseaver tseaver requested a review from crwilcox October 17, 2018 19:13
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 17, 2018
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

@crwilcox the kokoro build for api_core is failing for what look like spurious branch coverage issues: both of the lines are in the middle of functions, with no branch point in sight.

@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

I'm merging anyway to fix the lint import bit on master.

@tseaver tseaver merged commit f0449e0 into googleapis:master Oct 17, 2018
@tseaver tseaver deleted the 6211-api_core-fix_lint branch October 17, 2018 19:31
@tseaver
Copy link
Contributor Author

tseaver commented Oct 17, 2018

@crwilcox The branch coverage failures are for the lambda _: True callbacks passed in to bidi.ResumableBidiRpc() ?!?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox approved these changes

Assignees
No one assigned
Labels
api: core cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tseaver @crwilcox @googlebot