Implementing JsonProperty in ndb.
#6447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhermes
commented
Nov 7, 2018
| @@ -2082,6 +2083,11 @@ def _db_get_value(self, v, unused_p): | |||
| class PickleProperty(BlobProperty): | |||
| """A property that contains values that are pickle-able. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| Unlike most property types, a :class:`PickleProperty` is **not** | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -1463,6 +1463,7 @@ def test_constructor_explicit(): | |||
| write_empty_list=False, | |||
| ) | |||
| assert prop._name == b"blob_val" and prop._name != "blob_val" | |||
| assert prop._compressed | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| Returns: | ||
| bytes: The ``value``, JSON encoded as an ASCII byte string. | ||
| """ | ||
| as_str = json.dumps(value, separators=(",", ":"), ensure_ascii=True) |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
dhermes
commented
Nov 8, 2018
chrisrossi
reviewed
Nov 8, 2018
chrisrossi
reviewed
Nov 8, 2018
abec152 to
19cb5ea
Compare
|
@chrisrossi PTAL, I made |
chrisrossi
pushed a commit
to chrisrossi/google-cloud-python
that referenced
this pull request
Feb 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.