Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Spanner: Add PingingPool to toplevel spanner module #6886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 10, 2018
Merged

Spanner: Add PingingPool to toplevel spanner module #6886

merged 3 commits into from
Dec 10, 2018

Conversation

crwilcox
Copy link
Contributor

No description provided.

@crwilcox crwilcox added the api: spanner Issues related to the Spanner API. label Dec 10, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 10, 2018
@crwilcox
Copy link
Contributor Author

crwilcox commented Dec 10, 2018 •
edited
Loading

The documentation at https://gcloud-python.readthedocs.io/en/stable/spanner/session-api.html#google.cloud.spanner.pool.PingingPool (not this clients but reasonable enough) states you can access it this way but you cannot as it was not included.

tseaver
tseaver reviewed Dec 10, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably be adding the other pool classes, too (FixedSizePool is there already):

  • AbstractSessionPool (users who write their own pool implementations need it.
  • BurstyPool
  • TransactionPingingPool

@crwilcox
Copy link
Contributor Author

Current list of impls is below. I can add TransactionPingingPool as well


__all__ = (
    "__version__",
    "AbstractSessionPool",
    "BurstyPool",
    "Client",
    "COMMIT_TIMESTAMP",
    "enums",
    "FixedSizePool",
    "KeyRange",
    "KeySet",
    "param_types",
    "PingingPool",
    "types",
)

@crwilcox crwilcox force-pushed the add-pingingpool-to-spanner-alias branch from aa6c2d4 to 7aff218 Compare December 10, 2018 20:21
@crwilcox crwilcox merged commit a43f885 into googleapis:master Dec 10, 2018
@crwilcox crwilcox deleted the add-pingingpool-to-spanner-alias branch December 10, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crwilcox @tseaver @googlebot