Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Storage: add missing call to batch.begin() in example. #6932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 17, 2018
Merged

Storage: add missing call to batch.begin() in example. #6932

merged 1 commit into from
Dec 17, 2018

Conversation

sorced-jim
Copy link
Contributor

This should have an email that matches a CLA.

@sorced-jim sorced-jim requested a review from crwilcox as a code owner December 16, 2018 22:30
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 16, 2018
@tseaver tseaver changed the title Add missing call to batch.begin() in example. Storage: add missing call to batch.begin() in example. Dec 17, 2018
tseaver
tseaver approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although not really required for the example (begin is more of a hook for the Transaction subclass), it does show usage, which would prevent reuse of a previously begun batch.

@tseaver tseaver added api: datastore Issues related to the Datastore API. type: docs Improvement to the documentation for an API. labels Dec 17, 2018
@tseaver tseaver merged commit db75dda into googleapis:master Dec 17, 2018
@tseaver
Copy link
Contributor

tseaver commented Dec 17, 2018

Thanks for the patch, @sorced-jim!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API. cla: yes This human has signed the Contributor License Agreement. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sorced-jim @tseaver @googlebot