Update error in system tests that expect error for wrong location #7286
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to get BadRequest for querying with the wrong location. Now we get NotFound. I update the test to just look for the base class of GoogleAPICallError, since it seems we aren't guarnteed the actual status code.
Merged
Contributor
|
@tswast do we know which change caused this? |
shollyman
approved these changes
Feb 4, 2019
Contributor
Author
|
@crwilcox Something in the backend. Still trying to identify the specific CL. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to get BadRequest for querying with the wrong location. Now we
get NotFound. I update the test to just look for the base class of
GoogleAPICallError, since it seems we aren't guarnteed the actual status
code.