Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adds a ready event to BackgroundConsumer to wait on start. #7499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Adds a ready event to BackgroundConsumer to wait on start. #7499

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5731cf9
Adds a ready event to BackgroundConsumer to allow waiting for the bac…
crwilcox Mar 11, 2019
f1508ed
incorporate feedback from dpcollins to further limit the scope of ready
crwilcox Mar 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions api_core/google/api_core/bidi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,8 +505,9 @@ def _on_call_done(self, future):
# when the RPC has terminated.
self.resume()

def _thread_main(self):
def _thread_main(self, ready):
try:
ready.set()
self._bidi_rpc.add_done_callback(self._on_call_done)
self._bidi_rpc.open()

Expand Down Expand Up @@ -555,11 +556,19 @@ def _thread_main(self):
def start(self):
"""Start the background thread and begin consuming the thread."""
with self._operational_lock:
ready = threading.Event()
thread = threading.Thread(
name=_BIDIRECTIONAL_CONSUMER_NAME, target=self._thread_main
name=_BIDIRECTIONAL_CONSUMER_NAME,
target=self._thread_main,
args=(ready,)
)
thread.daemon = True
thread.start()
# Other parts of the code rely on `thread.is_alive` which
# isn't sufficient to know if a thread is active, just that it may
# soon be active. This can cause races. Further protect
# against races by using a ready event and wait on it to be set.
ready.wait()
self._thread = thread
_LOGGER.debug("Started helper thread %s", thread.name)

Expand Down