Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@crazystick
Copy link
Contributor

@crazystick crazystick commented Jun 5, 2019

There's no easy way to inject your own Worker thread that I can see, but I don't know why you wouldn't want to know the original time of the log entry.

Closes #8222

@crazystick crazystick requested a review from tseaver as a code owner June 5, 2019 18:09
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jun 5, 2019
@crazystick
Copy link
Contributor Author

I signed it!

@tseaver tseaver changed the title set the actual timestamp of the log record, fixes #8222 Logging: Set the 'timestamp' on log records created by handler. Jun 5, 2019
@tseaver tseaver added the api: logging Issues related to the Cloud Logging API. label Jun 5, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 5, 2019

@busunkim96 Can you check why the CLA bot is not responding here?

@busunkim96
Copy link
Contributor

busunkim96 commented Jun 5, 2019

@crazystick I did a manual lookup and don't see a CLA on file for your GitHub account. Would you mind going through the process one more time?

Thank you!

@crazystick
Copy link
Contributor Author

@busunkim96 I signed a corporate CLA and I guess it took a little time to process, but I see it now listed at https://cla.developers.google.com/clas. Maybe give your bot another kick!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jun 6, 2019
@tseaver
Copy link
Contributor

tseaver commented Jun 6, 2019

@crazystick Thanks for the patch!

@tseaver tseaver merged commit fae0d5b into googleapis:master Jun 6, 2019
@tseaver tseaver mentioned this pull request Jun 11, 2019
tseaver pushed a commit that referenced this pull request Jun 24, 2019
parthea pushed a commit that referenced this pull request Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Logging: issues with out-of-sync clocks

4 participants