Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Apr 29, 2015

Uses #847 as a base.

Per #827.

@jgeewax, PTAL (particuarly at 4e1d2c9).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 29, 2015
@dhermes
Copy link
Contributor

dhermes commented Apr 29, 2015

Does this have another PR as a diffbase?

Overall LGTM.

I noticed you added a forgotten method to pubsub-usage. Any reason we don't just use the Sphinx autodoc features so we don't have to worry about stuff like that?

This comment was marked as spam.

This comment was marked as spam.

@jgeewax
Copy link
Contributor

jgeewax commented Apr 29, 2015

LGTM

@tseaver
Copy link
Contributor Author

tseaver commented Apr 29, 2015

Does this have another PR as a diffbase?

#847 (the original description says so.

Overall LGTM.

I noticed you added a forgotten method to pubsub-usage. Any reason we don't just use the Sphinx
autodoc features so we don't have to worry about stuff like that?

This isn't API reference documentation -- it is "common pattern" / usage docs.

tseaver added a commit that referenced this pull request Apr 29, 2015
@tseaver tseaver merged commit d21bc3f into googleapis:master Apr 29, 2015
@tseaver tseaver deleted the 827-pubsub_docs_short_form_imports branch April 29, 2015 19:57
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e59bf11 on tseaver:827-pubsub_docs_short_form_imports into 9568703 on GoogleCloudPlatform:master.

parthea pushed a commit that referenced this pull request Aug 21, 2025
* build: use multiScm for Kokoro release builds

Source-Link: googleapis/synthtool@0da1658
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5cddfe2fb5019bbf78335bc55f15bc13e18354a56b3ff46e1834f8e540807f05

* add constraints file for python 3.13

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Linchin <[email protected]>
parthea pushed a commit that referenced this pull request Sep 16, 2025
* build: use multiScm for Kokoro release builds

Source-Link: googleapis/synthtool@0da1658
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:5cddfe2fb5019bbf78335bc55f15bc13e18354a56b3ff46e1834f8e540807f05

* add constraints file for python 3.13

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Linchin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants