Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove type information for kwargs to not conflict with type checkers #8546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

Remove type information for kwargs to not conflict with type checkers #8546

merged 1 commit into from
Jul 1, 2019

Conversation

crwilcox
Copy link
Contributor

@crwilcox crwilcox commented Jul 1, 2019

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 1, 2019
@crwilcox crwilcox force-pushed the kwargs-not-dict-type branch from 29da539 to d0fb2f7 Compare July 1, 2019 15:43
@crwilcox crwilcox mentioned this pull request Jul 1, 2019
Closed
@crwilcox crwilcox force-pushed the kwargs-not-dict-type branch from d0fb2f7 to ed0c63e Compare July 1, 2019 15:47
@crwilcox crwilcox added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 1, 2019
@tseaver
Copy link
Contributor

tseaver commented Jul 1, 2019

Unrelated Storage flake reported in #8552.

@crwilcox crwilcox merged commit e6898be into master Jul 1, 2019
@crwilcox crwilcox deleted the kwargs-not-dict-type branch July 1, 2019 20:08
parthea pushed a commit that referenced this pull request Oct 21, 2023
@crwilcox
Fixes #8545 by removing typing information for kwargs to not conflict…
0683b74 
… with type checkers (#8546)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 Awaiting requested review from busunkim96

@frankyn frankyn Awaiting requested review from frankyn

1 more reviewer

@tseaver tseaver tseaver approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crwilcox @tseaver @googlebot @yoshi-kokoro