Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@busunkim96
Copy link
Contributor

This pull request was generated using releasetool.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 11, 2019
@tseaver tseaver added the api: dns Issues related to the Cloud DNS API. label Jul 11, 2019
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge if the answer to my question below is "No".

name = 'google-cloud-dns'
description = 'Google Cloud DNS API client library'
version = '0.30.1'
version = '0.30.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the endpoint change is worth signalling with a minor release?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back to ask folks doing this in other languages what they're doing Will leave it open for now.

@busunkim96 busunkim96 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jul 11, 2019
@busunkim96
Copy link
Contributor Author

Merging as a patch, as other languages have done the same.

@busunkim96 busunkim96 merged commit 0f06c34 into googleapis:master Jul 16, 2019
@yoshi-automation
Copy link
Contributor

@yoshi-automation
Copy link
Contributor

The release build has started, the log can be viewed here. 🌻

@yoshi-automation
Copy link
Contributor

🥚 You hatched a release! The release build finished successfully! 💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: dns Issues related to the Cloud DNS API. autorelease: published cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants