-
Notifications
You must be signed in to change notification settings - Fork 1.6k
#899: Harden 'Subscription.pull' against missing 'receivedMessages' in response #901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#899: Harden 'Subscription.pull' against missing 'receivedMessages' in response #901
Conversation
LGTM |
…receivedMessages #899: Harden 'Subscription.pull' against missing 'receivedMessages' in response
I think this has been reintroduced. I'm seeing the following in version 0.13.0: Exception in thread Thread-236: |
Hi, when are you going to release new version with this change? |
We can cut a release this week. @tseaver WDYT? |
Sure, no problem making a release soonish. |
@tseaver It would be great that you will release in these few days. Thank you! |
* feat: link stream to use _Connection and add unit tests * docstring * fix unit test in python 3.7 * add system test * lint * correct location for system test * fix system test * address comments * use dict for closing connections * switch back to use local variable for closed connections * removed unused variable
* feat: link stream to use _Connection and add unit tests * docstring * fix unit test in python 3.7 * add system test * lint * correct location for system test * fix system test * address comments * use dict for closing connections * switch back to use local variable for closed connections * removed unused variable
Fixes #899.