Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests(spanner): harden 'test_transaction_batch_update_w_syntax_error' #9395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2019
Merged

tests(spanner): harden 'test_transaction_batch_update_w_syntax_error' #9395

merged 1 commit into from
Oct 22, 2019

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 4, 2019

Closes #8474

@tseaver tseaver added testing api: spanner Issues related to the Spanner API. labels Oct 4, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 4, 2019
larkee
larkee approved these changes Oct 21, 2019
View reviewed changes
Copy link
Contributor

@larkee larkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming the import order is correct

@tseaver tseaver merged commit b93be69 into googleapis:master Oct 22, 2019
@tseaver tseaver deleted the 8474-spanner-unflake-test_transaction_batch_update_w_syntax_error branch October 22, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@frankyn frankyn Awaiting requested review from frankyn

1 more reviewer

@larkee larkee larkee approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spanner: 'test_transaction_batch_update_w_syntax_error' systest flakes with 409.
3 participants
@tseaver @larkee @googlebot