fix(speech): move 'speaker_tag' field from 'SpeakerDiarizationConfig' to 'WordInfo' (via synth) #9576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt library generator.
tseaver
approved these changes
Oct 31, 2019
| // speaker_tag is set if enable_speaker_diarization = 'true' and only in the | ||
| // top alternative. | ||
| int32 speaker_tag = 5 | ||
| [(google.api.field_behavior) = OUTPUT_ONLY]; | ||
| } |
There was a problem hiding this comment.
This is potentially a breaking change, although it looks obviously correct (the unchanged docstring implies that the speaker_tag should always have been associated with a word).
The field was added to SpeakerDiarizationConfig on 2019-09-24, which is later than any release of google-cloud-speech, so I think we can let it slide.
There was a problem hiding this comment.
This may be reverted tomorrow given discussions in the Yoshi chatroom. Will be keeping an eye on it.
atulep
pushed a commit
that referenced
this pull request
Apr 3, 2023
… to 'WordInfo' (via synth) (#9576)
atulep
pushed a commit
that referenced
this pull request
Apr 6, 2023
… to 'WordInfo' (via synth) (#9576)
atulep
pushed a commit
that referenced
this pull request
Apr 18, 2023
… to 'WordInfo' (via synth) (#9576)
parthea
pushed a commit
that referenced
this pull request
Oct 22, 2023
… to 'WordInfo' (via synth) (#9576)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated using Autosynth. 🌈
Log from Synthtool