Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(compute): revert proto3_optional, required removal on parent_id #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 20, 2022
Merged

fix(compute): revert proto3_optional, required removal on parent_id #714

merged 1 commit into from
Apr 20, 2022

Conversation

noahdietz
Copy link
Contributor

@noahdietz noahdietz commented Apr 20, 2022 •
edited
Loading

Fixes accidental breaking change in 249e9a1#r71665196.

@parthea parthea mentioned this pull request Apr 20, 2022
Merged
@noahdietz noahdietz marked this pull request as ready for review April 20, 2022 17:58
@noahdietz noahdietz requested a review from vam-google April 20, 2022 17:58
vam-google
vam-google approved these changes Apr 20, 2022
View reviewed changes
Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but cat you please remove exclamation mark from conventional commit message. It will make automation start eleasing compute libraries 2.x which I don't think what we want to do.

@noahdietz noahdietz changed the title fix(compute)!: revert proto3_optional, required removal on parent_id fix(compute): revert proto3_optional, required removal on parent_id Apr 20, 2022
@noahdietz noahdietz force-pushed the fix-move-parent-id branch from 3fd945f to f0cc68f Compare April 20, 2022 22:11
@noahdietz
Copy link
Contributor Author

but cat you please remove exclamation mark from conventional commit message

Done!

@noahdietz noahdietz merged commit 6b3fdce into master Apr 20, 2022
@noahdietz noahdietz deleted the fix-move-parent-id branch April 20, 2022 22:12
ghost
ghost reviewed Apr 20, 2022
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete ma accounts and all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@vam-google vam-google vam-google approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noahdietz @vam-google