WIP: Unsafe mutation split option #1956
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduskis
reviewed
Sep 28, 2018
| // split subSets into several entries of 100,000 | ||
| for (List<Mutation> mutations : subSets) { | ||
| ListenableFuture<MutateRowResponse> childFuture = sendDirect(entry.getRowKey(), mutations); | ||
| Futures.addCallback(childFuture, new FutureCallback<MutateRowResponse>() { |
There was a problem hiding this comment.
This callback needs to be created outside the for loop, otherwise, success will never be more than 1.
|
I thought we decided that this should be done only for the import job? |
|
@igorbernstein2, the use case in #1919 turned out to be a different use case. I suggested that the author submits a PR as WIP for the work so far, and we can add some discussion here. |
|
@elisheva-qlogic, can we close this, or is there more work to be done in this PR? |
|
We can close it |
gcf-owl-bot bot
added a commit
that referenced
this pull request
Apr 15, 2024
* feat: add libraries_bom_version * add unit tests * remove isfile * add tempdir * restore * add current dir * restore template * remove unit test * restore templates Source-Link: googleapis/synthtool@63cc541 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:dc11e2119c854b57b7f7ed9962391decf002454700020a52b5d0d46c40b80a7e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EXPERIMENTAL
Created unsafe mutation split option for bulk mutations