Refactored value provider #2025
Conversation
| } | ||
| ReadRowsRequest.Builder builder = Adapters.SCAN_ADAPTER.adapt(scan, readHooks); | ||
| request = StaticValueProvider.of(readHooks.applyPreSendHook(builder.build())); | ||
| request = new RequestWithScanValueProvider(scan.getStartRow(), scan.getStopRow(), |
There was a problem hiding this comment.
There's a BIgtableExtendedScan that needs to be considered here. This approach doesn't seem like it would work.
There was a problem hiding this comment.
I think that we will need to convert the Scan to a Filter and RowSet, even though we don't have all of the information that Query needs.
|
Question, would it not be easier to just use a valueprovider for the entire configuration object? |
|
@igorbernstein2, |
|
@igorbernstein2, we hade a problem at one point, but that was related to classpath issues. Now that we use hbase-client-shaded, it ought to work. |
|
Initial Implementation with |
|
@sduskis |
|
I think that something is being lost in translation. This doesn't look right. |
Refactoring
ReadRowsRequestcreation into a newRequestWithScanValueProvider. Now request.get() would have two different get()