Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FlatRowAdapter implementation of models.RowAdapter #2034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sduskis merged 6 commits into from
Jan 6, 2019
Merged

FlatRowAdapter implementation of models.RowAdapter #2034

sduskis merged 6 commits into from
Jan 6, 2019

Conversation

@rahulKQL
Copy link
Contributor

@rahulKQL rahulKQL commented Dec 19, 2018

Added new operation IBigtableDataClient#readRows(ReadRowsRequest) which currently return ResultScanner<Row>, with intend to delegate BigtableDataClient#readFlatRow for vaneer client.

Reason for raising this PR:

  • FlatRow and v2.models.Row has identical fields.
  • Vanner client has all read operation with v2.models.Row.

Assumption: RowCell has same ordering as FlatRow.Cell.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 19, 2018
@igorbernstein2
Copy link
Collaborator

igorbernstein2 commented Dec 19, 2018 •
edited
Loading

I think it would be better to keep the FlatRow abstraction in cloud-bigtable-client and instead pass a custom RowAdapter to readRowsCallable.

This would keep the existing api stable w/o any performance loss

@igorbernstein2
Copy link
Collaborator

igorbernstein2 commented Dec 19, 2018

See here for an example implementation:
https://github.com/googleapis/google-cloud-java/blob/master/google-cloud-clients/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/models/DefaultRowAdapter.java

@rahulKQL rahulKQL mentioned this pull request Dec 20, 2018
Closed
@rahulKQL
Copy link
Contributor Author

rahulKQL commented Dec 20, 2018

Thanks @igorbernstein2 for review. I have added FlatRowModelAdapter.java which we could use for BigtableDataClient#readRowsCallable later when BigtableDataClient vaneer client is ready.

When get a chance please have a look!!

igorbernstein2
igorbernstein2 approved these changes Dec 24, 2018
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Other then the nits, LGTM

@rahulKQL
Copy link
Contributor Author

rahulKQL commented Dec 27, 2018

@igorbernstein2,

whenever you get time, Please have a look.

igorbernstein2
igorbernstein2 approved these changes Dec 27, 2018
View reviewed changes
Copy link
Collaborator

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sduskis sduskis merged commit 5912e6e into googleapis:master Jan 6, 2019
@rahulKQL rahulKQL deleted the readRowMethod branch January 7, 2019 12:08
@rahulKQL rahulKQL mentioned this pull request Feb 6, 2019
Closed
@rahulKQL rahulKQL changed the title Adding implementation for readRows FlatRowAdapter implementation of models.RowAdapter Feb 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 approved these changes

@sduskis sduskis Awaiting requested review from sduskis

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rahulKQL @igorbernstein2 @sduskis @googlebot