Updating RowAdapter & hbase2_x-BigtableDataClient#readModifyRow() with GCJ's model #2061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
222721d to
426fdd8
Compare
rahulKQL
commented
Feb 5, 2019
...-core-parent/bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/BatchExecutor.java
Outdated
Show resolved
Hide resolved
sduskis
reviewed
Feb 5, 2019
| * @return an instance of {@link Row}. | ||
| */ | ||
| private Row transformResponse(ReadModifyWriteRowResponse response) { | ||
| public static Row transformResponse(ReadModifyWriteRowResponse response) { |
Contributor
There was a problem hiding this comment.
Please remove this method, and use RowAdapter instead. You should be able to call model.Row.toProto() for the adapter.
Contributor
There was a problem hiding this comment.
Sorry... we need a model.Row.fromProto() in order to do this.
Contributor
Author
There was a problem hiding this comment.
@sduskis I have updated BigtableDataClientWrapper & BulkMutation to use DefautlRowAdpater#createRowFromProto.
Please have a look. Thanks!!
426fdd8 to
1341fd9
Compare
Adding AsyncExecutor fix fix comments Row Adapter changes with SortedSet Updated RowAdapter changes with fromProto Started using DefaultRowAdapter#createRowFromProto for Protobuf to models.Row conversion
1341fd9 to
83e6bc8
Compare
sduskis
approved these changes
Feb 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changes this PR contains
Updated BigtableAsyncTable with gcj's Row to implement IBigtableClientWrapper.
NOTE
This PR is on dependent on #2056 & #2058 once those two are merged, we can rebase and have min less than 5 files changes.