Removing WhileMatchFilter logic from RowAdapter. #2080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| String previousFamily = null; | ||
| for (FlatRow.Cell cell : cells) { | ||
| // Cells with labels are for internal use, do not return them. | ||
| // TODO(kevinsi4508): Filter out targeted {@link WhileMatchFilter} labels. |
Collaborator
There was a problem hiding this comment.
Is this the right place for this? It seems like a filter specific thing, but FlatRowAdapter seems to be generic. Would a ReadHook be a better place?
Contributor
Author
There was a problem hiding this comment.
ReadHook updates the ReadRowsRequest, not the results. We would need to figure out some other mechanism.
This PR at least brings attention to the problem, so if it's ok, I'd like to proceed with merging this code, and figure out a better alternative later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2056 for context