Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Conversation

Neenu1995
Copy link
Contributor

No description provided.

@Neenu1995 Neenu1995 requested a review from a team as a code owner November 8, 2021 16:18
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 8, 2021
@Neenu1995 Neenu1995 added owlbot:ignore instruct owl-bot to ignore a PR do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Nov 8, 2021
@Neenu1995 Neenu1995 marked this pull request as draft November 8, 2021 16:19
@Neenu1995 Neenu1995 changed the title [DO_NOT_MERGE]chore: downstream check for all libraries in single script [DO_NOT_MERGE]chore: downstream check for all libraries in single job Nov 8, 2021
Copy link
Contributor

@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few suggestions, otherwise LGTM

fail-fast: false
matrix:
java: [17]
repo:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any comments? how to update, auto update, ?

cd ${scriptDir}/..

# Make java core library artifacts available for 'mvn validate' at the bottom
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V -q
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding -ntp -fae


# run dependencies script
cd ..
mvn -Denforcer.skip=true clean install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding -ntp -fae

popd
fi

mvn -Denforcer.skip=true clean install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding -ntp -fae

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing. downstream-check:run owlbot:ignore instruct owl-bot to ignore a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants