Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: multiple dbs support #1102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jun 8, 2023
Merged

feat: multiple dbs support #1102

merged 10 commits into from
Jun 8, 2023

Conversation

kolea2
Copy link
Contributor

@kolea2 kolea2 commented Jun 6, 2023

This PR consists of cherry picks from the https://github.com/googleapis/java-datastore/tree/multi-db branch. They include:

#928
#940
#942

This also enables parameterized testing for ITDatastoreTest.

@kolea2 kolea2 requested review from a team as code owners June 6, 2023 15:43
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jun 6, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/nightly/integration.cfg
  • .kokoro/nightly/java11-integration.cfg
  • .kokoro/presubmit/graalvm-native.cfg
  • .kokoro/presubmit/integration.cfg

@product-auto-label product-auto-label bot added the api: datastore Issues related to the googleapis/java-datastore API. label Jun 6, 2023
@kolea2 kolea2 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 6, 2023
@kolea2 kolea2 mentioned this pull request Jun 6, 2023
Closed
jainsahab
jainsahab suggested changes Jun 7, 2023
View reviewed changes
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
jainsahab
jainsahab approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@jainsahab jainsahab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
@kolea2 kolea2 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 8, 2023
@kolea2 kolea2 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit 7887f32 into googleapis:main Jun 8, 2023
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 8, 2023
@kolea2 kolea2 deleted the mutli-db-to-main branch June 8, 2023 15:34
@release-please release-please bot mentioned this pull request Jun 8, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jainsahab jainsahab jainsahab approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
api: datastore Issues related to the googleapis/java-datastore API. size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kolea2 @jainsahab @yoshi-kokoro