Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

feat: Instant support#1586

Merged
tom-andersen merged 2 commits into
googleapis:mainfrom
eranl:instant
Feb 27, 2024
Merged

feat: Instant support#1586
tom-andersen merged 2 commits into
googleapis:mainfrom
eranl:instant

Conversation

@eranl

@eranl eranl commented Feb 25, 2024

Copy link
Copy Markdown
Contributor

Add support for java.time.Instant as a time type.

Fixes #509☕️

feat: Instant support
@eranl eranl requested a review from a team February 25, 2024 02:26
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: firestore Issues related to the googleapis/java-firestore API. labels Feb 25, 2024
@tom-andersen tom-andersen added owlbot:run Add this label to trigger the Owlbot post processor. and removed owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 26, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 26, 2024
@eranl eranl requested a review from a team February 26, 2024 19:16
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Feb 26, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@tom-andersen tom-andersen added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 27, 2024

@tom-andersen tom-andersen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tom-andersen tom-andersen merged commit 77a9bfc into googleapis:main Feb 27, 2024
@eranl eranl deleted the instant branch September 5, 2024 01:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replacing Timestamp with Java8 Instant or ability to use custom serializer

3 participants