Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

Fix Instant-record merge#1805

Merged
milaGGL merged 1 commit into
googleapis:mila/test-recordfrom
eranl:mila/test-record
Sep 5, 2024
Merged

Fix Instant-record merge#1805
milaGGL merged 1 commit into
googleapis:mila/test-recordfrom
eranl:mila/test-record

Conversation

@eranl

@eranl eranl commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

This is a fix for the rebase of this branch onto main.
In a separate PR, I have changed the method CustomClassMapper.applyFieldAnnotations, which is being moved in the record branch to class BeanMapper.
This PR applies the change to that method, which was lost in the rebase, in its new location.

@eranl eranl requested a review from a team September 5, 2024 03:38
@conventional-commit-lint-gcf

conventional-commit-lint-gcf Bot commented Sep 5, 2024

Copy link
Copy Markdown

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label Bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/java-firestore API. labels Sep 5, 2024

@milaGGL milaGGL left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for catching this.

@milaGGL milaGGL merged commit 11a8930 into googleapis:mila/test-record Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants