This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: Transaction.get(AggregateQuery) added#1029
Merged
Merged
Conversation
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
5bb721e to
b6a2556
Compare
…onRespectReadTime()
ehsannas
approved these changes
Sep 7, 2022
ehsannas
left a comment
Contributor
There was a problem hiding this comment.
Great! One minor fix needed pointed out below.
| RunAggregationQueryResponse.newBuilder() | ||
| .setResult( | ||
| AggregationResult.newBuilder() | ||
| .putAggregateFields("count", Value.newBuilder().setIntegerValue(42).build()) |
| } | ||
|
|
||
| @Test | ||
| public void aggregateQueryInATransactionShouldLockTheCountedDocuments() throws Exception { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.