Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

docs: AggregateQuery.java: describe why we ignore subsequent responses #1041

Merged
dconeybe merged 2 commits into from
Sep 23, 2022
Merged

docs: AggregateQuery.java: describe why we ignore subsequent responses #1041

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033db3c
docs: AggregateQuery.java: describe why we ignore subsequent responses
dconeybe Sep 22, 2022
4679e34
Merge remote-tracking branch 'origin/main' into AggregateQueryOnRespo…
dconeybe Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions google-cloud-firestore/src/main/java/com/google/cloud/firestore/AggregateQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ public void onStart(StreamController streamController) {

@Override
public void onResponse(RunAggregationQueryResponse response) {
// Ignore subsequent response messages. The RunAggregationQuery RPC returns a stream of
// responses (rather than just a single response); however, only the first response of the
// stream is actually used. Any more responses are technically errors, but since the Future
// will have already been notified, we just drop any unexpected responses.
if (!isFutureNotified.compareAndSet(false, true)) {
return;
}
Expand Down