Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

test: Re-enable aggregateQueryInATransactionShouldRespectReadTime when run against the emulator #1050

Merged
dconeybe merged 1 commit into from
Sep 30, 2022
Merged

test: Re-enable aggregateQueryInATransactionShouldRespectReadTime when run against the emulator #1050

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions google-cloud-firestore/src/test/java/com/google/cloud/firestore/it/ITQueryCountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import static com.google.common.truth.Truth.assertThat;
import static java.util.Collections.singletonMap;
import static org.junit.Assert.assertThrows;
import static org.junit.Assume.assumeFalse;
import static org.junit.Assume.assumeTrue;

import com.google.api.core.ApiFuture;
Expand Down Expand Up @@ -300,16 +299,6 @@ public void aggregateQueryInATransactionShouldRespectReadTime() throws Exception
.build());

Long transactionCount = transactionFuture.get();

// Put this assumption as close to the end of this method as possible, so that at least the code
// above can be _executed_, even if we end up skipping the assertThat() check below.
assumeFalse(
"Snapshot reads are not yet implemented in the Firestore emulator (b/220918135). "
+ "As a result, this test will fail when run against the Firestore emulator "
+ "because it will incorrectly ignore the read time and return the count "
+ "of the documents at the current time.",
isRunningAgainstFirestoreEmulator());

assertThat(transactionCount).isEqualTo(5);
}

Expand Down