This repository was archived by the owner on May 8, 2026. It is now read-only.
feat: Logical termination for firestore.getAll(...).#1517
Merged
Conversation
Contributor
Author
|
This improves the performance for 2 cases: (1) we know we expect 3 responses, so we can return the result after we receive 3 docs. (2) This simply calls (b/309863147) |
cherylEnkidu
approved these changes
Jan 5, 2024
cherylEnkidu
left a comment
Contributor
There was a problem hiding this comment.
Hi Ehsan, I change the unit tests to verify the changes. Please only merge the PR If my changes look good to you,
…ot run with logical termination
Contributor
|
Hi @ehsannas , please verify my latest fix before merging the PR. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.