Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on May 8, 2026. It is now read-only.

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing#513

Merged
schmidt-sebastian merged 2 commits into
masterfrom
mrschmidt/fixtodate
Jan 26, 2021
Merged

fix: don't throw NPE in DocumentSnapshot.getDate() when value is missing#513
schmidt-sebastian merged 2 commits into
masterfrom
mrschmidt/fixtodate

Conversation

@schmidt-sebastian

Copy link
Copy Markdown
Contributor

Fixes #491

@schmidt-sebastian schmidt-sebastian requested review from a team January 26, 2021 21:50
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 26, 2021
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the googleapis/java-firestore API. label Jan 26, 2021
@codecov

codecov Bot commented Jan 26, 2021

Copy link
Copy Markdown

Codecov Report

Merging #513 (a650223) into master (0e6f3da) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
- Coverage     74.09%   74.08%   -0.02%     
+ Complexity     1117     1108       -9     
============================================
  Files            66       66              
  Lines          5883     5884       +1     
  Branches        723      726       +3     
============================================
  Hits           4359     4359              
  Misses         1296     1296              
- Partials        228      229       +1     
Impacted Files Coverage Δ Complexity Δ
...a/com/google/cloud/firestore/DocumentSnapshot.java 80.85% <50.00%> (-0.87%) 39.00 <1.00> (ø)
.../com/google/cloud/firestore/BulkWriterOptions.java 100.00% <0.00%> (ø) 2.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e6f3da...a650223. Read the comment docs.

@thebrianchen thebrianchen left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@schmidt-sebastian schmidt-sebastian merged commit a41b07e into master Jan 26, 2021
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/fixtodate branch January 26, 2021 23:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: firestore Issues related to the googleapis/java-firestore API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Null field value is treated inconsistently in DocumentSnapshot get{Type} methods (return null vs throw NPE)

2 participants