-
Notifications
You must be signed in to change notification settings - Fork 17
test: verifying test, lint, clirr, and graalvm in checks #456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
b75e431
test: verifying test, lint, and clirr in checks
suztomo a26f843
Merge remote-tracking branch 'origin/main' into lint_downstream
suztomo c344f2c
test: renaming job name
suztomo e9af28f
test: reverted dependencies job and adding build jobs
suztomo 1c8a91a
ci: apt-get update before installing libxml2-utils
suztomo 6219a7b
ci: adding the new builds as required checks
suztomo ea5a008
Merge remote-tracking branch 'origin/main' into lint_downstream
suztomo 83941f6
test: trying graalvm job-type
suztomo 8fc7aed
test: graalvm not for handwritten library
suztomo dc4cf3e
ci: setup graalvm
suztomo c5cd072
test: added comment and upgraded GitHub Actions
suztomo 168cc88
ci: testing old GraalVM version
suztomo 1d090e9
ci: using GraalVM 22.0.0.2
suztomo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
on: | ||
push: | ||
branches: | ||
- main | ||
pull_request: | ||
|
||
# Keeping this file separate as the dependencies check would use more | ||
# repositories than needed this downstream check for GraalVM native image and | ||
# other Maven plugins. | ||
name: downstream | ||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
java: [8, 11] | ||
repo: | ||
# GAPIC library | ||
- java-trace | ||
# Handwritten library | ||
- java-bigquery | ||
job-type: | ||
- test # maven-surefire-plugin | ||
- lint # fmt-maven-plugin and google-java-format | ||
- clirr # clirr-maven-plugin | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-java@v3 | ||
with: | ||
distribution: zulu | ||
java-version: ${{matrix.java}} | ||
- run: java -version | ||
- run: sudo apt-get update -y | ||
- run: sudo apt-get install libxml2-utils | ||
- run: .kokoro/client-library-check.sh ${{matrix.repo}} ${{matrix.job-type}} | ||
|
||
# GraalVM job ensures the compatibility of GraaVM version above and the | ||
# native-maven-plugin version. | ||
graalvm: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
java: [11] | ||
repo: | ||
# GAPIC library that doesn't use a real GCP project in integration tests | ||
- java-orgpolicy | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: stCarolas/setup-maven@v4 | ||
with: | ||
maven-version: 3.8.1 | ||
- uses: ayltai/setup-graalvm@v1 | ||
with: | ||
java-version: ${{matrix.java}} | ||
# When a new version of native-maven-plugin fails to run in a downstream | ||
# library, it's likely to be an incompatibility with the GraalVM version. | ||
# In that case, you need to upgrade the Docker container used in the | ||
# tests in the downstream repositories (not just this value below). | ||
# Example: https://github.com/googleapis/testing-infra-docker/pull/195 | ||
graalvm-version: 22.0.0.2 | ||
Comment on lines
+57
to
+62
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added an instruction on how to upgrade GraalVM version in testing-infra-docker. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you! |
||
native-image: true | ||
- run: java -version | ||
- run: sudo apt-get update -y | ||
- run: sudo apt-get install libxml2-utils | ||
- run: .kokoro/client-library-check.sh ${{matrix.repo}} graalvm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Neenu1995 @mpeddada1 Do we allow/ban this GitHub Actins?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as it doesn't access our secrets we are fine with using any action. But this one looks like it is not being actively developed anymore. So may not be a good long term solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I'll use this then.
I see the owner maintains the repository. https://github.com/ayltai/setup-graalvm/commits/master
When we need alternative we can just use
curl
and unzip the content.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad. I saw the last release was in May 2021. Looks like it is being being actively developed.