Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Allow docletPath to be specified as a user property #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2022
Merged

chore: Allow docletPath to be specified as a user property #496

merged 1 commit into from
Jul 27, 2022

Conversation

meltsufin
Copy link
Member

No description provided.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jul 26, 2022
@lqiu96
Copy link
Member

lqiu96 commented Jul 27, 2022 •
edited
Loading

@meltsufin Tested with mvn clean javadoc:aggregate -P docFX -DdocletPath=/usr/local/google/home/lawrenceqiu/IdeaProjects/java-docfx-doclet-1.7.0.jar and using a (different) default doclet path. Both work as intended, so I believe this should work.

I can update the monorepo kokoro script to use -DdocletPath=${KOKORO_GFILE_DIR}/v1.7.0.jar and the split repos will use the set ${docletPath}

lqiu96
lqiu96 reviewed Jul 27, 2022
View reviewed changes
pom.xml
</activation>
<properties>
<!-- default config values -->
<docletName>java-docfx-doclet-1.5.0</docletName>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest release for doclet is v1.6.0 not sure why this wasn't ever updated

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update it in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll create a PR

@meltsufin meltsufin marked this pull request as ready for review July 27, 2022 14:50
@meltsufin meltsufin requested a review from a team as a code owner July 27, 2022 14:50
@meltsufin meltsufin merged commit e7d94e3 into main Jul 27, 2022
@meltsufin meltsufin deleted the doclet-path-user-prop branch July 27, 2022 14:51
@lqiu96 lqiu96 mentioned this pull request Sep 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lqiu96 lqiu96 lqiu96 approved these changes

Assignees
No one assigned
Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meltsufin @lqiu96