Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Mar 3, 2026. It is now read-only.

fix: do not automatically set overrideUnlockedRetention#2421

Merged
ddelgrosso1 merged 1 commit into
googleapis:mainfrom
ddelgrosso1:fix-retention-lock
Mar 7, 2024
Merged

fix: do not automatically set overrideUnlockedRetention#2421
ddelgrosso1 merged 1 commit into
googleapis:mainfrom
ddelgrosso1:fix-retention-lock

Conversation

@ddelgrosso1

@ddelgrosso1 ddelgrosso1 commented Mar 5, 2024

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 requested review from a team March 5, 2024 15:17
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: storage Issues related to the googleapis/nodejs-storage API. labels Mar 5, 2024
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 5, 2024
@ddelgrosso1 ddelgrosso1 merged commit c781bdc into googleapis:main Mar 7, 2024
@ddelgrosso1 ddelgrosso1 deleted the fix-retention-lock branch March 7, 2024 19:30
@release-please release-please Bot mentioned this pull request Mar 7, 2024
Merged
@50Fifty 50Fifty mentioned this pull request May 23, 2024
Open
@YoutacRandS-VA YoutacRandS-VA mentioned this pull request Jun 19, 2024
Open
@dizzylilly dizzylilly mentioned this pull request Aug 3, 2024
Open
@Stanislav1975 Stanislav1975 mentioned this pull request Aug 9, 2024
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@danielduhh danielduhh danielduhh approved these changes
@danielbankhead danielbankhead danielbankhead approved these changes
@JesseLovelace JesseLovelace JesseLovelace approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the googleapis/nodejs-storage API. size: s Pull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ddelgrosso1 @danielduhh @danielbankhead @JesseLovelace