This repository was archived by the owner on Jul 20, 2023. It is now read-only.
feat: make vision helpers work with JSON proto#441
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 97.67% 97.61% -0.06%
==========================================
Files 3 3
Lines 86 84 -2
==========================================
- Hits 84 82 -2
Misses 2 2
Continue to review full report at Codecov.
|
bcoe
approved these changes
Sep 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #431 by loading JSON proto instead of using
GoogleProtoFilesRootfrom gax. In helpers, we only need aFeatureenum, and it's very easy to get it by reading a JSON proto and making aprotobuf.Rootout of it. This code will work both with regular gRPC and in a fallback scenario.