Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

chore: run the generator, fix synth script#755

Merged
alexander-fenster merged 2 commits into
masterfrom
manualsynth
Apr 10, 2020
Merged

chore: run the generator, fix synth script#755
alexander-fenster merged 2 commits into
masterfrom
manualsynth

Conversation

@alexander-fenster

@alexander-fenster alexander-fenster commented Apr 10, 2020

Copy link
Copy Markdown
Contributor

We have a ❄️ synth.py here (because of manual helpers) and it turned out the eslint-disable rule was added directly to the autogenerated code in #568 (I'm delighted to report that it was me who screwed up :) )

Fixing it properly, by making sure the eslint-disable won't get overwritten.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 10, 2020
@alexander-fenster alexander-fenster changed the title chore: run th generator, fix synth script chore: run the generator, fix synth script Apr 10, 2020
xiaozhenliu-gg5
xiaozhenliu-gg5 approved these changes Apr 10, 2020
View reviewed changes

@xiaozhenliu-gg5 xiaozhenliu-gg5 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Alex for fixing this.

@alexander-fenster alexander-fenster added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@alexander-fenster

alexander-fenster commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

System test apparently failed because the API did not detect Google label here:

Google logo

It works locally, restart should help.

@xiaozhenliu-gg5

xiaozhenliu-gg5 commented Apr 10, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

I think it was me who added the eslint-disable lines in the generated code and forgot to include them in synth.py. :(

@alexander-fenster

alexander-fenster commented Apr 10, 2020

Copy link
Copy Markdown
Contributor Author

System tests are fine (import * as vision from '../src'; in system-test/vision.ts). Those that are "smoke tests" still use require but we can refactor them later.

@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 10, 2020
@codecov

codecov Bot commented Apr 10, 2020

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@00a2993). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #755   +/-   ##
=========================================
  Coverage          ?   97.82%           
=========================================
  Files             ?       15           
  Lines             ?    13759           
  Branches          ?      592           
=========================================
  Hits              ?    13460           
  Misses            ?      294           
  Partials          ?        5
Impacted Files Coverage Δ
src/v1p3beta1/index.ts 100.00% <0.00%> (ø)
src/v1p2beta1/index.ts 100.00% <0.00%> (ø)
src/v1/product_search_client.ts 98.11% <0.00%> (ø)
src/v1p1beta1/image_annotator_client.ts 93.68% <0.00%> (ø)
src/v1p4beta1/image_annotator_client.ts 96.90% <0.00%> (ø)
src/helpers.ts 100.00% <0.00%> (ø)
src/v1p4beta1/product_search_client.ts 98.17% <0.00%> (ø)
src/v1p3beta1/image_annotator_client.ts 96.53% <0.00%> (ø)
src/v1p2beta1/image_annotator_client.ts 94.86% <0.00%> (ø)
src/v1/image_annotator_client.ts 97.31% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00a2993...a41fc96. Read the comment docs.

@alexander-fenster alexander-fenster merged commit 1c2b903 into master Apr 10, 2020
@alexander-fenster alexander-fenster deleted the manualsynth branch April 10, 2020 20:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bcoe bcoe Awaiting requested review from bcoe

2 more reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@xiaozhenliu-gg5 xiaozhenliu-gg5 xiaozhenliu-gg5 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexander-fenster @xiaozhenliu-gg5 @JustinBeckwith @googlebot @yoshi-kokoro