Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

Codecov Report

Merging #782 into master will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #782      +/-   ##
==========================================
- Coverage   98.38%   98.31%   -0.07%     
==========================================
  Files          15       15              
  Lines       14155    14155              
  Branches      612      612              
==========================================
- Hits        13926    13917       -9     
- Misses        224      233       +9     
  Partials        5        5              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfa6869...60b7d19. Read the comment docs.

@tofutim thanks for the contribution. @alexander-fenster, I believe this change would need to be made int he generator if this is something we want to do?

Yes, this is the right place to do it.

Given that now we have googleapis/gax-nodejs#803 merged, the fix seems valid (we could not do it before since it would've broken the webpack usecase).
I can make this change in the generator so that it applies to all libraries.

Having that said, @tofutim can you give us some details - why would you need that? Is it for Electron?

More details:

• if you use webpack or similar bundlers, they will respect browser field of google-gax so will go into the fallback mode by default. No need to do it here once more.
• Electron does not respect browser field, so technically there is a problem with using the libraries in Electron Chromium context. The problem can be avoided by using a bundler (the same webpack) that will do it properly for you.
• Users might still want to use fallback for non-browser (e.g. Node.js) scenarios.

Taken care of by #793 (that code is auto-generated).