Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Jul 20, 2023. It is now read-only.

fix: add types to package.json#977

Merged
galz10 merged 2 commits into
googleapis:mainfrom
galz10:missing-types
Jan 6, 2022
Merged

fix: add types to package.json#977
galz10 merged 2 commits into
googleapis:mainfrom
galz10:missing-types

Conversation

@galz10

@galz10 galz10 commented Jan 6, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #971 🦕

@galz10 galz10 requested review from a team January 6, 2022 19:17
@product-auto-label product-auto-label Bot added the api: vision Issues related to the googleapis/nodejs-vision API. label Jan 6, 2022
@galz10 galz10 mentioned this pull request Jan 6, 2022
Closed
@galz10 galz10 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2022
@tmatsuo

tmatsuo commented Jan 6, 2022

Copy link
Copy Markdown

Can you update the description to include the bug?

@galz10

galz10 commented Jan 6, 2022

Copy link
Copy Markdown
Contributor Author

@tmatsuo added the issue this fixes

@galz10 galz10 merged commit 1cd056b into googleapis:main Jan 6, 2022
@galz10 galz10 deleted the missing-types branch January 6, 2022 22:17
gcf-merge-on-green Bot pushed a commit that referenced this pull request Jan 6, 2022
@release-please
chore: release 2.4.2 (#978)
5d38db9 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.4.2](https://www.github.com/googleapis/nodejs-vision/compare/v2.4.1...v2.4.2) (2022-01-06)


### Bug Fixes

* add types to package.json ([#977](https://www.github.com/googleapis/nodejs-vision/issues/977)) ([1cd056b](https://www.github.com/googleapis/nodejs-vision/commit/1cd056b97c851eac1726610c85193ddc85cbddb7))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@kweinmeister kweinmeister mentioned this pull request Feb 15, 2022
Closed
4 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@bcoe bcoe bcoe approved these changes

@marcushultman marcushultman marcushultman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: vision Issues related to the googleapis/nodejs-vision API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing types in package.json

4 participants

@galz10 @tmatsuo @bcoe @marcushultman