Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Presubmits fail with RecursionError: maximum recursion depth exceeded while calling a Python object when using protobuf at HEAD #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
parthea opened this issue Jan 23, 2024 · 0 comments · Fixed by #433
Closed

Presubmits fail with RecursionError: maximum recursion depth exceeded while calling a Python object when using protobuf at HEAD #425

parthea opened this issue Jan 23, 2024 · 0 comments · Fixed by #433
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@parthea
Copy link
Contributor

parthea commented Jan 23, 2024

See PR #423
See build log here: https://github.com/googleapis/proto-plus-python/actions/runs/7576004395/job/20633856887?pr=423

____________________________________________________________________________________________________ test_message_pb ____________________________________________________________________________________________________

    def test_message_pb():
>       class Foo(proto.Message):

tests/test_message.py:205: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
proto/message.py:275: in __new__
    file_info.generate_file_pb(new_class=cls, fallback_salt=full_name)
proto/_file_info.py:113: in generate_file_pb
    pb_message = reflection.GeneratedProtocolMessageType(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:166: in __init__
    descriptor.GetOptions().message_set_wire_format):
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:239: in GetOptions
    self._LazyLoadOptions()
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:219: in _LazyLoadOptions
    features = self._ResolveFeatures(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:176: in _ResolveFeatures
    features.CopyFrom(self._parent._GetFeatures())
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:158: in _GetFeatures
    self._LazyLoadOptions()
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:205: in _LazyLoadOptions
    features = self._ResolveFeatures(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:180: in _ResolveFeatures
    unresolved.CopyFrom(raw_options.features)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:744: in getter
    field_value = field._default_constructor(self)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:450: in MakeSubMessageDefault
    message_factory.GetMessageClass(message_type)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/message_factory.py:50: in GetMessageClass
    return _InternalCreateMessageClass(descriptor)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/message_factory.py:109: in _InternalCreateMessageClass
    result_class = _GENERATED_PROTOCOL_MESSAGE_TYPE(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:174: in __init__
    _AttachFieldHelpers(cls, field)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:269: in _AttachFieldHelpers
    is_repeated = field_descriptor.label == _FieldDescriptor.LABEL_REPEATED
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:722: in label
    self._GetFeatures().field_presence
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:158: in _GetFeatures
    self._LazyLoadOptions()
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:219: in _LazyLoadOptions
    features = self._ResolveFeatures(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:176: in _ResolveFeatures
    features.CopyFrom(self._parent._GetFeatures())
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:158: in _GetFeatures
    self._LazyLoadOptions()
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:205: in _LazyLoadOptions
    features = self._ResolveFeatures(
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/descriptor.py:180: in _ResolveFeatures
    unresolved.CopyFrom(raw_options.features)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:744: in getter
    field_value = field._default_constructor(self)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/internal/python_message.py:450: in MakeSubMessageDefault
    message_factory.GetMessageClass(message_type)
.nox/unit-3-10/lib/python3.10/site-packages/google/protobuf/message_factory.py:50: in GetMessageClass
    return _InternalCreateMessageClass(descriptor)
E   RecursionError: maximum recursion depth exceeded while calling a Python object
!!! Recursion detected (same locals & position)
@parthea parthea added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 23, 2024
parthea added a commit that referenced this issue Feb 13, 2024
@parthea
workaround issue #425
8ea8426
parthea added a commit that referenced this issue Feb 13, 2024
@parthea
workaround issue #425
39e4d33
parthea added a commit that referenced this issue Feb 13, 2024
@parthea
workaround issue #425
62b37ee
This was referenced Feb 14, 2024
Closed
Merged
@parthea parthea mentioned this issue May 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add compatibility with protobuf==5.x googleapis/proto-plus-python
1 participant
@parthea