fix: Fix the issue with empty package name #341
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. It looks good, although I don't remember if the Protobuf team actually resolved this issue. You mentioned it was solved in 4.21.6 - where did you get that ? |
|
When I had the issue I was using version 4.21.5 and after the suggestion on a SO question, I've tested it with the newer version 4.21.6 and the issue was gone. |
|
Hi @atulep , please could you take another look? |
|
Converting to draft as #389 needs to be completed first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This subsequently fixes the issue with nested messages reported in #340.